Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't have translucent background on image post thumbnail click #625

Merged
merged 3 commits into from
Jun 15, 2023
+1 −1
Merged

don't have translucent background on image post thumbnail click #625

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df357cd
make image preview with 0.8 alpha black atop the normal background, t…
Jun 15, 2023
24568c5
Merge branch 'main' into no_translucent_image_post_preview
Jun 15, 2023
6739795
Merge branch 'main' into no_translucent_image_post_preview
dessalines Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
make image preview with 0.8 alpha black atop the normal background, t… 
…his makes it easier to see the image without the background interfering so much
Vijay Ramesh committed Jun 15, 2023
commit df357cd19bdf9c8dcc8cd9f47798fca5330c0d19
2 changes: 1 addition & 1 deletion app/src/main/java/com/jerboa/ui/components/common/ImageViewerDialog.kt
View file
Original file line number Diff line number Diff line change
@@ -73,7 +73,7 @@ fun ImageViewerDialog(url: String, onBackRequest: () -> Unit) {
}

val backColor = MaterialTheme.colorScheme.scrim
val backColorTranslucent = MaterialTheme.colorScheme.scrim.copy(alpha = 0.4f)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually do really like the background translucence, but I agree 40% in way too little... it should be like 10-20% . Could you try that out and see how it looks?

val backColorTranslucent = MaterialTheme.colorScheme.scrim.copy(alpha = 0.8f)

var showTopBar by remember { mutableStateOf(true) }