Add contentDescription to all relevant components

[pipe01]

Hopefully I didn't miss anything. There are still some components with contentDescription = null because they don't represent anything by themselves and/or don't have any actions, for example the icons in settings menu items.

Fixes #175.

[dessalines]

This will have to come after #447 so you'll probably have to merge from therei

[shortwavesurfer2009]

Some of the strings seem a bit wordy. For the bottomBar may i suggest "Home" "Communities" "Notifications" "Bookmarks" and "Profile"?

Otherwise this looks fantastic

Edit: the personProfile_viewAvatar and personProfile_viewBanner should likely say " Avatar image" and "Banner image" unless i am misunderstanding and they are buttons.

[dessalines]

#447 is merged now, so you can merge from main.

I'll make sure to grep for all those contentDescriptions to make sure we've got them all before I approve.

[pipe01]

There are some conflicts where #447 adds a specific key and I have added a more generic one (e.g. create_report_back vs goBack), which should I keep?

Also for @shortwavesurfer2009's comment, I'm not sure which way would be best so it's up to @dessalines.

[pipe01]

the personProfile_viewAvatar and personProfile_viewBanner should likely say " Avatar image" and "Banner image" unless i am misunderstanding and they are buttons

They open up the image in the image viewer when pressed, so they kinda are buttons.

[dessalines]

goBack is probably fine.

They open up the image in the image viewer when pressed, so they kinda are buttons.

I'm good either way, I don't know if there's a convention for image buttons, but the word button seems fine.

I imagine most of the strings already exist in strings.xml, so only create new ones if its really necessary. I leave the rest up to you.

[pipe01]

Should be good now.

[dessalines]

Found a few more:

• AppBars L75
• DrawerItem: 59
• Several in the pictrsimage file.
• A bunch that were set to null

Do a Find in Files and search for contentDescription to get the rest of them.

[pipe01]

Most of them are set to null on purpose, I'm thinking of adding some constant that's set to null to indicate that it's unnecessary.

[pipe01]

Is there anything blocking this?

[twizmwazin]

@pipe01 If you can fix the merge conflicts I'll merge it right away

[pipe01]

Done