Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #421 #422

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Fix #421 #422

merged 1 commit into from
Jun 6, 2023

Conversation

7heo
Copy link
Contributor

@7heo 7heo commented Jun 5, 2023

Hopefully this fixes #421. I know nothing about Kotlin or Jetpack, so please HMU if I did something bad :)

@7heo 7heo requested a review from dessalines as a code owner June 5, 2023 19:25
@7heo 7heo force-pushed the main branch 2 times, most recently from 61ae52f to 6523786 Compare June 5, 2023 21:13
@7heo
Copy link
Contributor Author

7heo commented Jun 5, 2023

@dessalines how can I access the logs of the failed checks? thanks!

Edit: Ok, never mind, I get "access denied" when trying to log in on the CI. I guess it's due to that.

@7heo 7heo force-pushed the main branch 5 times, most recently from 382f27a to c02db1e Compare June 6, 2023 00:08
@7heo
Copy link
Contributor Author

7heo commented Jun 6, 2023

Ok, I learned a bit about Kotlin, and hopefully this bug can be fixed if this is merged 🎉

scope.launch {
account?.also { acct ->
url = uploadPictrsImage(acct, imageIs, ctx).orEmpty()
if (uri != null && uri != Uri.EMPTY) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it can't hurt. Thanks!

@dessalines dessalines merged commit 930e416 into LemmyNet:main Jun 6, 2023
pipe01 pushed a commit to pipe01/jerboa that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a new post with an image and cancelling the image selection crashes Jerboa
2 participants