Add .editorconfig
#405
Merged
Add .editorconfig
#405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
dessalines
reviewed
Jun 4, 2023
| @@ -16,9 +16,6 @@ plugins { | |||
|
|
|||
| subprojects { | |||
| apply plugin: "org.jmailen.kotlinter" // Version should be inherited from parent | |||
| kotlinter { | |||
There was a problem hiding this comment.
Upgrade kotlinter in L13 to 3.14.0, and this should pass.
There was a problem hiding this comment.
Weird that this worked for me locally. Perhaps I didn't run ./gradlew lintKotlin after removing the kotlinter-config.
Anyway, if I upgrade to either 3.14.0 or 3.15.0 we get other rule violations, as those versions enforce additional rules. All of those rules are automatically formattable, but as per the last PR, I'll leave that formatting commit to you.
You can create it by calling ./gradlew formatKotlin - it mostly adds trailing commas to basically everything.
`ktlint` follows the rules in this file.
`kotlinter` already follows `.editorconfig`, making this redundant.
oscarnylander
force-pushed
the
editorconfig
branch
from
f1b95fc to
f340413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ktlintfollows the rules in this file.For the sake of simplicity, the rules in the file are aligned with what's in place in the project already. No additional formatting is necessary after this PR is merged.