Collapse comments by tapping directly on the comment body #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dy or header, and expand comments by tapping on the comment header. This replaces the old behaviour (tap and hold on comment headers), which wasn't as intuitive for new users. Tested on comment markdown text as well as "View source" text. Tested clickable links and usernames are still clickable.
dessalines
reviewed
Jun 4, 2023
| @@ -86,7 +86,7 @@ fun CommentNodeHeader( | |||
| score: Int, | |||
| myVote: Int?, | |||
| isModerator: Boolean, | |||
| onLongClick: () -> Unit = {} | |||
| onClick: () -> Unit = {} | |||
There was a problem hiding this comment.
Follow the convention on these components, which is to make sure there's no default. IE
onClick: () -> Unit
| @@ -118,7 +118,8 @@ fun CommentNodeHeaderPreview() { | |||
| @Composable | |||
| fun CommentBody( | |||
| comment: Comment, | |||
| viewSource: Boolean | |||
| viewSource: Boolean, | |||
| onClick: () -> Unit = {} | |||
| @@ -56,7 +56,7 @@ fun CommentMentionNodeHeader( | |||
| onPersonClick: (personId: Int) -> Unit, | |||
| score: Int, | |||
| myVote: Int?, | |||
| onLongClick: () -> Unit = {} | |||
| onClick: () -> Unit = {} | |||
| @@ -56,7 +56,7 @@ fun CommentReplyNodeHeader( | |||
| onPersonClick: (personId: Int) -> Unit, | |||
| score: Int, | |||
| myVote: Int?, | |||
| onLongClick: () -> Unit = {} | |||
| onClick: () -> Unit = {} | |||
| @@ -215,8 +215,8 @@ fun CommentOrPostNodeHeader( | |||
| bottom = MEDIUM_PADDING | |||
| ) | |||
| .combinedClickable( | |||
| onLongClick = onLongClick, | |||
| onClick = {} | |||
| onLongClick = {}, | |||
There was a problem hiding this comment.
Could you create a github issue for long-click voting? I think that'd be really nice to have.
| @@ -674,11 +674,13 @@ fun PreviewLines( | |||
| @Composable | |||
| fun MyMarkdownText( | |||
| markdown: String, | |||
| color: Color = MaterialTheme.colorScheme.onSurface | |||
| color: Color = MaterialTheme.colorScheme.onSurface, | |||
| onClick: () -> Unit = {} | |||
|
Once you get around to this, don't worry about the merge conflicts, I'll handle those. |
|
Had to touch a few more files for this due to not providing a default implementation for onClick parameters, let me know if the merge is a pain and I can rebase on head. |
|
I got it, it'll be merged shortly after the CI passes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now collapse comments by tapping anywhere on the comment body or header, and expand comments again by tapping on the comment header. This replaces the old behaviour (tap and hold on comment headers), which wasn't as intuitive for new users.
Tested on comment markdown text as well as "View source" comment text. Tested clickable links in the comment body and usernames in the comment header are still clickable.