Improve baseline documentation + update baseline profiles #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
reviewed
Jun 13, 2024
CONTRIBUTING.md
Outdated
| Be warned that this task will take a long time to run (+30m) and can fail. | ||
|
|
||
| You will also need to set the variant of `app` to `benchmarkRelease`, | ||
| have no device connected and it should start a emulator with the correct settings. |
| ## Updating the Baseline profiles | ||
|
|
||
| You can generate the latest baseline profiles by executing the following gradle task. | ||
| It will generate the baseline profiles and the startup profiles. |
There was a problem hiding this comment.
Should be on the same line, unless it's a new paragraph.
There was a problem hiding this comment.
The advantages of Markdown is that you can write your sentences line by line but they will be properly merged in the rendered document.
I don't have softwrap, so else its a long line to write/read but if you prefer it, I can change it
There was a problem hiding this comment.
I've always found that weird bc it makes viewing the file in an editor very different from how it looks rendered. Up to you I spose.
dessalines
approved these changes
Jun 13, 2024
| ## Updating the Baseline profiles | ||
|
|
||
| You can generate the latest baseline profiles by executing the following gradle task. | ||
| It will generate the baseline profiles and the startup profiles. |
There was a problem hiding this comment.
I've always found that weird bc it makes viewing the file in an editor very different from how it looks rendered. Up to you I spose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.