Fixing view votes crash. Fixes #1357 #1379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
commented
Feb 15, 2024
| @@ -4,3 +4,4 @@ const val DEBOUNCE_DELAY = 1000L | |||
| const val MAX_POST_TITLE_LENGTH = 200 | |||
| const val DEFAULT_FONT_SIZE = 16 | |||
| const val INSTANCE_FONT_SIZE = 9 | |||
| const val VIEW_VOTES_LIMIT = 40L | |||
There was a problem hiding this comment.
Upped this to 40, because sometimes if the votes are less than the screen height, it won't think you're scrolled down, and smartly append.
There was a problem hiding this comment.
i don't follow but you can always put like maxSize modifier.
MV-GH
reviewed
Feb 15, 2024
| getDeduplicateMerge( | ||
| oldRes.data.comment_likes, | ||
| newRes.data.comment_likes, | ||
| ) { it.creator.id } |
There was a problem hiding this comment.
Is that unique per commentLike post?
There was a problem hiding this comment.
Yep, user can only like an item once.
MV-GH
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.