Dont show metadata title if it matches the post title. #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessalines
changed the title
MV-GH
requested changes
Feb 11, 2024
| text = post.embed_title!!, | ||
| style = MaterialTheme.typography.titleLarge, | ||
| ) | ||
| if (post.name !== post.embed_title) { |
There was a problem hiding this comment.
Isn't triple equals direct reference comparison? Isn't this not guaranteed to be true for strings? (Two the dame strings can have different references) Or did they change this behaviour with Kotlin? Either way I would do !=
There was a problem hiding this comment.
Fixed. Didn't know that made a difference for strings.
There was a problem hiding this comment.
In Java each (string) object has its own unique ref, == is a direct reference comparison and equals is the overloaded logical comparison. But Java caches Strings and thus returns sometimes the same ref for the same string. So it works for some cases but not all. In Kotlin == is logical comparison (the equals) and === is the reference comparison
MV-GH
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.