Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using muted federated names. #1368

Merged
merged 13 commits into from
Feb 12, 2024
Merged

Using muted federated names. #1368

merged 13 commits into from
Feb 12, 2024

Conversation

dessalines
Copy link
Member

@dessalines dessalines commented Feb 10, 2024 •
edited
Loading

Main:

Screenshot_2024-02-11-18-30-21-244-edit_com jerboa debug

Comments:

Screenshot_2024-02-11-18-30-34-845-edit_com jerboa debug

dessalines
dessalines commented Feb 11, 2024
View reviewed changes
app/src/main/java/com/jerboa/ui/components/common/TextBadge.kt Outdated
null
}

Text(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the main change.

@dessalines dessalines marked this pull request as ready for review February 11, 2024 17:09
@dessalines dessalines marked this pull request as draft February 11, 2024 20:39
MV-GH
MV-GH requested changes Feb 11, 2024
View reviewed changes
Copy link
Collaborator

@MV-GH MV-GH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great!

app/src/main/java/com/jerboa/ui/components/common/TextBadge.kt Outdated
}

Text(
text = buildAnnotatedString {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how expensive this is but i would encase this in a remember with the color and title as key

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could do that but I don't see why its necessary, since its state never changes within this composable.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it shouldn't if the composable is skippable. But I haven't checked yet that it is. Else it would recompose each time anyway even if the state didn't change

app/src/main/java/com/jerboa/ui/components/common/TextBadge.kt Outdated
instanceColor: Color = MaterialTheme.colorScheme.onSurface.muted,
instanceStyle: TextStyle = MaterialTheme.typography.labelSmall,
) {
val serverStr = if (!local) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really fan of mixing ifs and their equivalents, But you can keep this if you want

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it up.

@dessalines dessalines marked this pull request as ready for review February 12, 2024 00:00
@dessalines
Copy link
Member Author

I've done a little more tweaking, and updated the pictures.

@dessalines dessalines merged commit 8c9c615 into main Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV-GH MV-GH MV-GH approved these changes

@twizmwazin twizmwazin Awaiting requested review from twizmwazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use full federated names, but use styling to mute / make the instance smaller
2 participants
@dessalines @MV-GH