Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making swipe colors softer. #1347

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Making swipe colors softer. #1347

merged 1 commit into from
Feb 5, 2024

Conversation

dessalines
Copy link
Member

@dessalines dessalines commented Feb 5, 2024 •
edited
Loading

This uses the container / onContainer variants as outlined in the material v3 color design docs.

Light theme:

Screenrecorder-2024-02-05-14-43-22-409_0_COMPRESSED.mp4

Dark Theme:

Screenrecorder-2024-02-05-14-43-35-582_0_COMPRESSED.mp4

cc @Snow4DV

@Snow4DV
Copy link
Contributor

Snow4DV commented Feb 5, 2024

Looks good and no collisions between colors, personally like it

MV-GH
MV-GH approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@MV-GH MV-GH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see the vid but this is probably better

@dessalines dessalines merged commit 95d9186 into main Feb 5, 2024
@dessalines
Copy link
Member Author

Sweet. I'll get a release out shortly.

@MV-GH MV-GH deleted the fix_swipe_colors branch February 5, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV-GH MV-GH MV-GH approved these changes

@twizmwazin twizmwazin Awaiting requested review from twizmwazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dessalines @Snow4DV @MV-GH