Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Russian translations #1300

Merged
merged 10 commits into from
Dec 18, 2023
Merged

Improve Russian translations #1300

merged 10 commits into from
Dec 18, 2023

Conversation

mittwerk
Copy link
Contributor

No description provided.

MV-GH
MV-GH approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@MV-GH MV-GH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Those entries that you marked non translatable if they had some translations could you remove them?

@MV-GH MV-GH changed the title main Improve Russian translations Dec 17, 2023
@mittwerk
Copy link
Contributor Author

Well, you can take them back, but I don't think it's necessary to translate it into any language.

@MV-GH
Copy link
Collaborator

MV-GH commented Dec 17, 2023 •
edited
Loading

I agree that's why I asked if they already have translations that you would remove them.

dessalines
dessalines requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on with all these formatting and dependency changes? Just update the translations only.

@MV-GH
Copy link
Collaborator

MV-GH commented Dec 18, 2023

Make a separate PR for those build changes

dessalines
dessalines approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thx

@dessalines dessalines enabled auto-merge (squash) December 18, 2023 16:09
@dessalines dessalines merged commit 14f081f into LemmyNet:main Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

@MV-GH MV-GH MV-GH approved these changes

@twizmwazin twizmwazin Awaiting requested review from twizmwazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mittwerk @MV-GH @dessalines