Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zooming difficulties #1237

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Fix zooming difficulties #1237

merged 2 commits into from
Sep 15, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Sep 15, 2023 •
edited
Loading

We used nested scrolling before to enable flick to exit behaviour, But nested scrolling doesn't work well compose and causes subtle issues. Thus I replaced it this with library which uses dragged instead.

see https://programming.dev/post/2375491

Fixes #1232

rhgjfNohMg.mp4

dessalines
dessalines approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it out now, its a little fidgety (IE sometimes when you 2-finger-zoom it thinks its flicking away, but still better than what it was.

@dessalines dessalines merged commit a4beb5d into LemmyNet:main Sep 15, 2023
@MV-GH MV-GH deleted the fix/weird_zooming branch September 15, 2023 13:11
dessalines added a commit that referenced this pull request Sep 15, 2023
@dessalines
Revert "Fix zooming difficulties (#1237)"
16cd832 
This reverts commit a4beb5d.
@dessalines dessalines mentioned this pull request Sep 15, 2023
Merged
dessalines added a commit that referenced this pull request Sep 19, 2023
@dessalines @MV-GH
Revert "Fix zooming difficulties" and temporary remove Swipe to exit …
ec2aef7 
…in ImageViewer (#1238)

* Revert "Fix zooming difficulties (#1237)"

This reverts commit a4beb5d.

* Remove swipe to exit in ImageViewer

---------

Co-authored-by: maarten.vercruysse <maarten.vercruysse@outlook.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

@twizmwazin twizmwazin Awaiting requested review from twizmwazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weird behaviour, image viewer zooming
2 participants
@MV-GH @dessalines