-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support private tabs for FireFox #1216
Conversation
Extra read here: https://github.com/mozilla-mobile/firefox-android/blob/fenix-v117.0/fenix/app/src/main/java/org/mozilla/fenix/IntentReceiverActivity.kt#L65 Key defined here: https://github.com/mozilla-mobile/firefox-android/blob/fenix-v117.0/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt#L1290
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this in the else section of the useCustomTab
if (usePrivateTab) {
intent.putExtra("com.google.android.apps.chrome.EXTRA_OPEN_NEW_INCOGNITO_TAB", true)
intent.putExtra("private_browsing_mode", true)
}
It is supposed to work too if you don't use a customtab
The option in the menu is "Use private custom tabs if available" so I just followed the current pattern for Chrome. This makes a lot of sense though, so I've changed this to always send the extras if the option is set, and update the option in the menu |
Extra read here:
https://github.com/mozilla-mobile/firefox-android/blob/fenix-v117.0/fenix/app/src/main/java/org/mozilla/fenix/IntentReceiverActivity.kt#L65
Key defined here:
https://github.com/mozilla-mobile/firefox-android/blob/fenix-v117.0/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt#L1290