Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use listing type use M3 dropdown instead of dialog #1150

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Use listing type use M3 dropdown instead of dialog #1150

merged 3 commits into from
Aug 7, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Aug 7, 2023

part of #1065

studio64_85F1c4xDIp.mp4

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 7, 2023 •
edited
Loading

for sortTypes imo it needs to centrally put them like it does now with dialogs

dessalines
dessalines reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this one, could you post before / after pics?

@MV-GH
Copy link
Collaborator Author

MV-GH commented Aug 7, 2023

There is a video, and the other looks the same as this but with different menu items

@dessalines
Copy link
Member

Oops my bad. Looks great.

@dessalines dessalines merged commit f47faef into LemmyNet:main Aug 7, 2023
@MV-GH MV-GH deleted the feat/m3_menu_listingtype branch August 7, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dessalines dessalines dessalines approved these changes

@twizmwazin twizmwazin Awaiting requested review from twizmwazin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MV-GH @dessalines