Make app bar 'more' buttons use dropdowns rather than dialogs #1146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camporter
requested review from
dessalines,
twizmwazin and
MV-GH
as code owners
MV-GH
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Ah, looks so much better now, thanks! I am planning on changing all dialogs to M3 menus. And for the post listing more options I was looking into https://github.com/saket/cascade. But bitesized PRs like this are better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some of the work for #1065 by moving more/three-dot buttons on top app bars over to use dropdowns rather than dialogs.
Whether to move other dialogs to dropdowns has some concerns in that issue (such as scrollable areas) and might be facilitated by other components, so this is limited intentionally.