Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dropdown popup issue #1063

Merged
merged 4 commits into from
Jul 20, 2023
Merged

Fix dropdown popup issue #1063

merged 4 commits into from
Jul 20, 2023

Conversation

MV-GH
Copy link
Collaborator

@MV-GH MV-GH commented Jul 19, 2023

Currently the popup for login disappears when typing. This actually works fine in the emulator but not on actual device.

Still not fan of this solution since you can see the popup disappear and appear when typing but it is improvement until a better fix is found.

Originally i had no onDismissRequest = {} but that also means that you have to select an option from the list or will not disappear. But when you add it, it works on emulator but not on actual device. Which makes it disappear when you type.

I tried a bunch of other solutions like disabling the dissmiss when typing but that had race condition issues.

before/current

studio64_PBUciULzg1.mp4

after

aHwCDVf6GN.mp4

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and it works great, thx.

@dessalines dessalines enabled auto-merge (squash) July 20, 2023 17:51
@dessalines dessalines merged commit e263502 into LemmyNet:main Jul 20, 2023
@MV-GH MV-GH deleted the bug/popup_login branch July 20, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants