Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all issue templates to github issue forms #1031

Merged
merged 13 commits into from
Jul 17, 2023
Merged

Change all issue templates to github issue forms #1031

merged 13 commits into from
Jul 17, 2023

Conversation

bappitybup
Copy link
Contributor

@bappitybup bappitybup commented Jul 13, 2023

  • Removed old .md issue templates (except questions / discussion)
  • Added new issue form github templates (syntax examples here)

NEW FEATURE REQUEST ISSUE FORM:

image

NEW BUG REPORT ISSUE FORM:

image

in the examples above:

  • the summary markdown at the bottom can be viewed and will not be submitted with the issue form
  • the issue templates submit the headings and the content entered by users below them (and also the checkboxes)
  • some input/textarea/checkbox fields have been made "required" so the submit button can only be pressed when they have content / have been updated
  • I have changed the question on the last checkbox to "This is not a question or discussion" rather than "Is this a question or a discussion" so that it can be checked instead of left alone

Some notes:

  • individual checkboxes can be made required or not required so I could change the last checkbox back to how it was and just make it not required.
  • I can change the Jerboa Version input field to a dropdown list of versions but then I'd have to update the dropdown list every time a new version is released which seems like a hassle

@bappitybup bappitybup changed the title Main issuetemplates Change all issue templates to github issue forms Jul 13, 2023
bappitybup added 4 commits July 13, 2023 18:20
same icons as LemmyNet/lemmy
in case of crash summary
to fix weird alignment (not indenting in summary)
@bappitybup
Copy link
Contributor Author

bappitybup commented Jul 13, 2023

https://github.com/bappitybup/testrepo/issues/new/choose <-- examples with the issue forms here that you can test

Copy link
Member

@dessalines dessalines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

individual checkboxes can be made required or not required so I could change the last checkbox back to how it was and just make it not required.

Yeah make them required if you would.

A dropdown for versions isn't necessary.

value: |
<details><summary>Click here if you don't know how to get the logs</summary>


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this, there's now a crash logs helper. Tell them to go to settings -> about -> Crash Logs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep that one, cuz the crash log helper wont help if the crash is on startup. And we have had a handfull of those.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should I just add some text in this summary dropdown for the crash log helper? or replace it altogether?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tell them to use the previous method if the crash is on startup else use the crash logs

Copy link
Contributor Author

@bappitybup bappitybup Jul 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see latest comment in PR, added two sections

===
image
===

FOR CRASHES ON STARTUP has the old content
FOR GENERAL CRASHES has this:

===
image
===

@bappitybup
Copy link
Contributor Author

bappitybup commented Jul 14, 2023

Thanks a ton!

individual checkboxes can be made required or not required so I could change the last checkbox back to how it was and just make it not required.

Yeah make them required if you would.

A dropdown for versions isn't necessary.

no prob 👌 all of them are already required
the only optional element in these issue forms is the textarea for crash logs

@bappitybup
Copy link
Contributor Author

bappitybup commented Jul 14, 2023

I have added two sections for startup crashes and general crashes, updated the example as well
--> https://github.com/bappitybup/testrepo/issues/new?assignees=&labels=bug%2Ctriage&projects=&template=bug_report.yaml

===
image
===

FOR CRASHES ON STARTUP has the old content
FOR GENERAL CRASHES has this:

===
image
===

@bappitybup bappitybup requested a review from dessalines July 15, 2023 11:26
> - Connect your phone to your PC
> - Execute this command on PC
>
> ### To enable developer options and USD DEBUGGING
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix my typo there, and ill approve it

@dessalines dessalines merged commit 38d8dd6 into LemmyNet:main Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants