Merge pull request bibendi#133 from bibendi/fix/run-args

fix: escape run args in shell mode
LeipeLeon · Jul 2, 2021 · bda3c26 · bda3c26
2 parents 854eed7 + 7d2c352
commit bda3c26
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/dip/commands/run.rb b/lib/dip/commands/run.rb
@@ -78,7 +78,11 @@ def published_ports
 
       def get_args
         if argv.any?
-          argv
+          if command[:shell]
+            [argv.shelljoin]
+          else
+            Array(default_args)
+          end
         elsif !(default_args = command[:default_args]).empty?
           if command[:shell]
             default_args.shellsplit

diff --git a/spec/lib/dip/commands/run_spec.rb b/spec/lib/dip/commands/run_spec.rb
@@ -45,7 +45,7 @@
 
   context "when publish is part of a command" do
     before { cli.start "run rails s --publish=3000:3000".shellsplit }
-    it { expected_exec("docker-compose", ["run", "--rm", "app", "rails", "s", "--publish=3000:3000"]) }
+    it { expected_exec("docker-compose", ["run", "--rm", "app", "rails", "s", "--publish\\=3000:3000"]) }
   end
 
   context "when run psql command without db name" do