Skip to content

Commit

Permalink
chore: use rubocop instead of standard
Browse files Browse the repository at this point in the history
  • Loading branch information
bibendi committed Nov 3, 2021
1 parent ee55d79 commit 7667687
Show file tree
Hide file tree
Showing 10 changed files with 23 additions and 35 deletions.
5 changes: 2 additions & 3 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,11 @@
<!--
Short description about the feature and the motivation/issue behind it
-->
-

## Related tickets


-

# What's inside

Expand All @@ -16,8 +17,6 @@ The purpose of this list is to track the progress if it's WIP (use checkboxes)
and to emphasize the critical parts (which you'd like to pay reviewers attention to)
-->
- [x] A
- [ ] B
- ...

# Checklist:

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ jobs:
gem install dip
dip provision
- name: Run linters
run: dip standardrb
run: dip rubocop
- name: Run tests
run: dip rspec
13 changes: 13 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
require: standard

inherit_gem:
standard: config/base.yml

AllCops:
TargetRubyVersion: 2.5
Exclude:
- 'tmp/**/*'
DisplayCopNames: true

Style/FrozenStringLiteralComment:
Enabled: true
1 change: 0 additions & 1 deletion .standard.yml

This file was deleted.

21 changes: 0 additions & 21 deletions LICENSE

This file was deleted.

2 changes: 1 addition & 1 deletion LICENSE.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2018 bibendi
Copyright (c) 2016 Mikhail Merkushin aka bibendi

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

# DIP

Docker Interaction Process
Docker Interaction Program.

A command-line utility that gives you the native-like interaction with applications through Docker in a development environment. In practice, it creates the feeling that you are working without mind-blowing approaches to run the containers.
Development-environment CLI program providing the native-like interaction with a Dockerized application. It creates the feeling that you are working without mind-blowing commands to run the containers.

<a href="https://evilmartians.com/?utm_source=dip">
<img src="https://evilmartians.com/badges/sponsored-by-evil-martians.svg" alt="Sponsored by Evil Martians" height="80" /></a>
Expand Down
2 changes: 0 additions & 2 deletions dip.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ lib = File.expand_path("lib", __dir__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require "dip/version"

# rubocop:disable Metrics/BlockLength
Gem::Specification.new do |spec|
spec.name = "dip"
spec.license = "MIT"
Expand Down Expand Up @@ -47,4 +46,3 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "simplecov", "~> 0.16"
spec.add_development_dependency "test-unit", "~> 3"
end
# rubocop:enable Metrics/BlockLength
6 changes: 3 additions & 3 deletions dip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ interaction:
service: app
command: bundle exec rspec

standardrb:
description: Run Standard commands
rubocop:
description: Run Rubocop commands
service: app
command: bundle exec standardrb
command: bundle exec rubocop

provision:
- cp -f lefthook-local.dip_example.yml lefthook-local.yml
Expand Down
2 changes: 1 addition & 1 deletion lefthook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ pre-commit:
rubocop:
tags: backend
glob: "**/*.rb"
runner: bundle exec standardrb --fix {staged_files} && git add {staged_files}
runner: bundle exec rubocop -A {staged_files} && git add {staged_files}

0 comments on commit 7667687

Please sign in to comment.