Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add meta data to pipeline. #42

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

pekasen
Copy link
Member

@pekasen pekasen commented Apr 19, 2024

Adds a Record-class with which data is wrapped and meta data are gathered through the pipeline. Adds additional tests for Record.py, NDJSONReader.py and TwacapicReader.py.

Coverage is now 60%

Adds a Record-class with which data is wrapped and meta data are gathered through the pipeline.
Adds additional tests for Record.py, NDJSONReader.py and TwacapicReader.py.

Coverage is now 60%
@pekasen pekasen added the enhancement New feature or request label Apr 19, 2024
@pekasen pekasen requested a review from FlxVctr April 19, 2024 15:35
@pekasen pekasen self-assigned this Apr 19, 2024
@pekasen pekasen linked an issue Apr 19, 2024 that may be closed by this pull request
Copy link
Member

@FlxVctr FlxVctr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks alright, but untested by me. Would be good to find a way to get the CI checks running on GH

children: List["Record"] = dataclasses.field(default_factory=list)

def split(self, key: str, id_key: Optional[str] = None) -> List["Record"]:
"""Split the record based on a key in the payload.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an example would help

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 59a8879.

@pekasen
Copy link
Member Author

pekasen commented Jul 4, 2024

looks alright, but untested by me. Would be good to find a way to get the CI checks running on GH

Yep, CI testing hangs itself on the dependency to smo-database, which is a private git-submodule as of yet. #45 removes this and testing is then available in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: transport metadata and emit diagnostics
2 participants