-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add meta data to pipeline. #42
base: trunk
Are you sure you want to change the base?
Conversation
Adds a Record-class with which data is wrapped and meta data are gathered through the pipeline. Adds additional tests for Record.py, NDJSONReader.py and TwacapicReader.py. Coverage is now 60%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks alright, but untested by me. Would be good to find a way to get the CI checks running on GH
children: List["Record"] = dataclasses.field(default_factory=list) | ||
|
||
def split(self, key: str, id_key: Optional[str] = None) -> List["Record"]: | ||
"""Split the record based on a key in the payload. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an example would help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 59a8879.
Yep, CI testing hangs itself on the dependency to |
Adds a Record-class with which data is wrapped and meta data are gathered through the pipeline. Adds additional tests for Record.py, NDJSONReader.py and TwacapicReader.py.
Coverage is now 60%