feat(lg-row-gap): adds new directive and classes #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* enables consumers to use the `row-gap` CSS property using Canopy and it's spacing. * accepts either a value or will default to `sm` row-gap. * fixes a broken link in the storybook grid style docs.
|
@markblandford looking good 👍 I think we can move it to |
elenagarrone
approved these changes
Oct 13, 2022
Xinchro
reviewed
Oct 13, 2022
| Add a row-gap to the flex elements using the row-gap | ||
| <a href="./?path=/docs/style-spacing--page">Canopy classes</a> | ||
| or <a href="./?path=/story/directives-row-gap--row-gap--row-gap">Canopy directive</a>. | ||
| </p> |
There was a problem hiding this comment.
might be being a little picky 😅 - i think this indentation is off
There was a problem hiding this comment.
I think we can fix this once we do the grid documentation
pauleustice
approved these changes
Oct 13, 2022
paul-request
approved these changes
Oct 13, 2022
|
🎉 This PR is included in version 9.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
row-gapCSS property using Canopy and it's spacing.smrow-gap.Follows on from the discussion #1046.
This draft PR is for master but I am open to it going into @next if required.
Checklist: