Skip to content

Conversation

@roro1506HD
Copy link
Contributor

This PR removes the spotless line endings restriction to UNIX. This makes the mod able to be built on Windows machines, which was unable to be done before this change because every java file of the project is encoded using Windows line endings

@lowercasebtw
Copy link
Member

I'm on windows? And it builds just fine

@roro1506HD
Copy link
Contributor Author

roro1506HD commented Dec 26, 2025

Are you using some special flags? When running ./gradlew build it fails with the following error:

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':spotlessJavaCheck'.
> The following files had format violations:
      src\main\java\btw\lowercase\skyboxify\command\SkyboxifyCommand.java
          @@ -1,50 +1,50 @@
          -/**\r\n
          - * Skyboxify\r\n
          - * A skybox mod that allows you to use OptiFine skies in Fabric 1.21+\r\n
          - * <p>\r\n
          - * Copyright (C) 2025 lowercasebtw\r\n
          - * Copyright (C) 2025 Contributors to the project retain their copyright\r\n
          - * <p>\r\n
          - * This program is free software: you can redistribute it and/or modify\r\n
          - * it under the terms of the GNU General Public License as published by\r\n
          - * the Free Software Foundation, either version 3 of the License, or\r\n
          - * (at your option) any later version.\r\n
          - * <p>\r\n
          - * This program is distributed in the hope that it will be useful,\r\n
          - * but WITHOUT ANY WARRANTY; without even the implied warranty of\r\n
          - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\r\n
          - * GNU General Public License for more details.\r\n
          - * <p>\r\n
          - * You should have received a copy of the GNU General Public License\r\n
          - * along with this program. If not, see <http://www.gnu.org/licenses/>.\r\n
          - * <p>\r\n
          - * "MINECRAFT" LINKING EXCEPTION TO THE GPL\r\n
          - */\r\n
          -\r\n
          -package btw.lowercase.skyboxify.command;\r\n
          -\r\n
          -import btw.lowercase.skyboxify.Skyboxify;\r\n
          -import btw.lowercase.skyboxify.screen.SkyboxListScreen;\r\n
          -import btw.lowercase.skyboxify.skybox.SkyboxManager;\r\n
          -import com.mojang.brigadier.Command;\r\n
          -import com.mojang.brigadier.builder.LiteralArgumentBuilder;\r\n
          -import net.fabricmc.fabric.api.client.command.v2.ClientCommandManager;\r\n
          -import net.fabricmc.fabric.api.client.command.v2.FabricClientCommandSource;\r\n
          -import net.minecraft.client.Minecraft;\r\n
          -\r\n
          -public class SkyboxifyCommand extends LiteralArgumentBuilder<FabricClientCommandSource> {\r\n
          -    public SkyboxifyCommand(String name) {\r\n
          -        super(name);\r\n
          -\r\n
          -        Minecraft minecraft = Minecraft.getInstance();\r\n
          -        executes((context) -> {\r\n
          -            minecraft.schedule(() -> minecraft.setScreen(Skyboxify.getConfig().getConfigScreen(minecraft.screen)));\r\n
          -            return Command.SINGLE_SUCCESS;\r\n
          -        });\r\n
          -\r\n
          -        then(ClientCommandManager.literal("debug").executes((context) -> {\r\n
          -            minecraft.schedule(() -> minecraft.setScreen(new SkyboxListScreen(minecraft.screen, SkyboxManager.getLoadedSkyboxes())));\r\n
          -            return Command.SINGLE_SUCCESS;\r\n
          -        }));\r\n
      ... (52 more lines that didn't fit)
  Violations also present in 43 other files.
  Run 'gradlew.bat spotlessApply' to fix all violations.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to generate a Build Scan (powered by Develocity).
> Get more help at https://help.gradle.org.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 10.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/9.2.0/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 4s
19 actionable tasks: 8 executed, 11 up-to-date

And when running ./gradlew spotlessApply it literally changes every single .java file with the UNIX line endings

@lowercasebtw
Copy link
Member

Run spotlessApply

@roro1506HD
Copy link
Contributor Author

When running that task, it changes every .java file with UNIX line endings, which then makes git want to push them at any time:

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   src/main/java/btw/lowercase/skyboxify/Skyboxify.java
        modified:   src/main/java/btw/lowercase/skyboxify/SkyboxifyClient.java
        modified:   src/main/java/btw/lowercase/skyboxify/command/SkyboxifyCommand.java
        modified:   src/main/java/btw/lowercase/skyboxify/config/ModMenuIntegration.java
        modified:   src/main/java/btw/lowercase/skyboxify/config/SkyboxifyConfig.java
        modified:   src/main/java/btw/lowercase/skyboxify/config/SkyboxifyConfigScreen.java
        modified:   src/main/java/btw/lowercase/skyboxify/events/LevelTickEvent.java
        modified:   src/main/java/btw/lowercase/skyboxify/events/SkyRenderEvent.java
        modified:   src/main/java/btw/lowercase/skyboxify/mixins/MixinClientLevel.java
        modified:   src/main/java/btw/lowercase/skyboxify/mixins/MixinGameRenderer.java
        modified:   src/main/java/btw/lowercase/skyboxify/mixins/MixinLevelRenderer.java
        modified:   src/main/java/btw/lowercase/skyboxify/mixins/MixinSkyRenderer.java
        modified:   src/main/java/btw/lowercase/skyboxify/mixins/RenderPipelinesAccessor.java
        modified:   src/main/java/btw/lowercase/skyboxify/screen/DebugScreen.java
        modified:   src/main/java/btw/lowercase/skyboxify/screen/SkyLayerInfoScreen.java
        modified:   src/main/java/btw/lowercase/skyboxify/screen/SkyLayerListScreen.java
        modified:   src/main/java/btw/lowercase/skyboxify/screen/SkyboxListScreen.java
        modified:   src/main/java/btw/lowercase/skyboxify/screen/widget/Gidget.java
        modified:   src/main/java/btw/lowercase/skyboxify/screen/widget/ScrollableList.java
        modified:   src/main/java/btw/lowercase/skyboxify/screen/widget/SimpleButton.java
        modified:   src/main/java/btw/lowercase/skyboxify/screen/widget/Text.java
        modified:   src/main/java/btw/lowercase/skyboxify/screen/widget/components/Box.java
        modified:   src/main/java/btw/lowercase/skyboxify/screen/widget/components/Scrollbar.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/SkyLayer.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/SkyPart.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/Skybox.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/SkyboxManager.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/SkyboxParser.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/SkyboxResourceHelper.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/SkyboxSkyRenderer.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/components/Biomes.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/components/Blend.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/components/Fade.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/components/Loop.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/components/Range.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/components/UV.java
        modified:   src/main/java/btw/lowercase/skyboxify/skybox/components/Weather.java
        modified:   src/main/java/btw/lowercase/skyboxify/utils/BlendFunction.java
        modified:   src/main/java/btw/lowercase/skyboxify/utils/CommonUtils.java
        modified:   src/main/java/btw/lowercase/skyboxify/utils/DynamicTransformsBuilder.java
        modified:   src/main/java/btw/lowercase/skyboxify/utils/IrisPipeline.java
        modified:   src/main/java/btw/lowercase/skyboxify/utils/IrisUtil.java
        modified:   src/main/java/btw/lowercase/skyboxify/utils/OldQuaternionMath.java
        modified:   src/main/java/btw/lowercase/skyboxify/utils/ParserCodecs.java

It's basically either git wants to push UNIX line endings, or I cannot compile without removing the spotless check

@lowercasebtw
Copy link
Member

Hmm, i've had it show them in intellij before like that but upon committing/pushing, it sees nothing changed and only pushes what really changed and makes them dissapear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants