Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loom and Legacy-Looming 1.5 - Fix Pom generation and enable parallelization back #160

Merged
merged 10 commits into from
Feb 22, 2024
Merged

Loom and Legacy-Looming 1.5 - Fix Pom generation and enable parallelization back #160

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dc038a0
Loom and Legacy-Looming 1.5
thecatcore Feb 11, 2024
9c9a9ee
Enable org.gradle.parallel
thecatcore Feb 21, 2024
bdaf57a
Update editorconfig
thecatcore Feb 21, 2024
31357d2
fix pom generation
thecatcore Feb 21, 2024
8d55ef4
Merge branch 'main' into feature/loom-1.5
thecatcore Feb 21, 2024
9c15b02
fix maven artifact name again
thecatcore Feb 21, 2024
fafd929
Fix concurrency errors on pom generation
thecatcore Feb 21, 2024
5fa0396
Fix concurrency errors because of shared artifactId
thecatcore Feb 21, 2024
fe7de53
Possible workaround concurrency issues
thecatcore Feb 21, 2024
91d2c45
Set back artifactId to normal
thecatcore Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix concurrency errors on pom generation
  • Loading branch information
@thecatcore
thecatcore committed Feb 21, 2024
commit fafd92990dee7adc20283a2281ce118df658d82f
13 changes: 7 additions & 6 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,12 +217,6 @@ def moduleDependencies(Project project, List<String> projectNames) {
project.publishing {
publications {
mavenJava(MavenPublication) {
if (getProjectSimpleName(project) == "legacyfabric-api") {
artifactId = "legacy-fabric-api"
} else {
artifactId = getProjectMavenName(project)
}

pom.withXml {
def depsNode = asNode().appendNode("dependencies")
deps.each {
Expand Down Expand Up @@ -488,9 +482,16 @@ subprojects {
publishing {
publications {
mavenJava(MavenPublication) {
if (getProjectSimpleName(project) == "legacyfabric-api") {
artifactId = "legacy-fabric-api"
} else {
artifactId = getProjectMavenName(project)
}

pom {
addPomMetadataInformation(project, pom)
}

artifact(remapJar) {
builtBy remapJar
}
Expand Down
Loading