Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace icons in extension with vscode icons #461

Merged
merged 2 commits into from
Oct 11, 2019
Merged

replace icons in extension with vscode icons #461

merged 2 commits into from
Oct 11, 2019

Conversation

hologerry
Copy link
Contributor

@hologerry hologerry commented Oct 10, 2019 •
edited
Loading

For issue #460

@jdneo
Copy link
Member

jdneo commented Oct 10, 2019

Thanks, will take a look later.

@jdneo
Copy link
Member

jdneo commented Oct 10, 2019

Hey @hologerry.

The globe icon works great from my side. Are you sure it's not working at your side?

image

BTW, I appended a commit to correct the color of the search icon in dark mode.

@jdneo jdneo added this to the 0.15.7 milestone Oct 10, 2019
@jdneo jdneo self-requested a review October 10, 2019 11:03
@hologerry
Copy link
Contributor Author

hologerry commented Oct 10, 2019 •
edited
Loading

For the stable VS Code version the globe icon works, however it does not work on the Insider VS Code version.
All icons are correct now on the latest stable VS Code version.

Screen Shot 2019-10-10 at 19 14 25

Screen Shot 2019-10-10 at 19 14 37

@jdneo
Copy link
Member

jdneo commented Oct 11, 2019

Thanks @hologerry

@jdneo jdneo merged commit eb77cd9 into LeetCode-OpenSource:master Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdneo jdneo jdneo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.7
Development

Successfully merging this pull request may close these issues.
2 participants
@hologerry @jdneo