Skip to content

Add side mode to webview #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 22, 2019
Prev Previous commit
Next Next commit
Make viewType readonly
  • Loading branch information
Vigilans committed Apr 21, 2019
commit 5bb71c87e1902883f542110132459ebf0747a0b9
2 changes: 1 addition & 1 deletion src/webview/LeetCodeWebview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { markdownEngine } from "./markdownEngine";

export abstract class LeetCodeWebview implements Disposable {

protected viewType: string = "leetcode.webview";
protected readonly viewType: string = "leetcode.webview";
protected panel: WebviewPanel | undefined;
private listeners: Disposable[] = [];

Expand Down
2 changes: 1 addition & 1 deletion src/webview/leetCodePreviewProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { markdownEngine } from "./markdownEngine";

class LeetCodePreviewProvider extends LeetCodeWebview {

protected viewType: string = "leetcode.preview";
protected readonly viewType: string = "leetcode.preview";
private node: IProblem;
private description: IDescription;
private sideMode: boolean = false;
Expand Down
2 changes: 1 addition & 1 deletion src/webview/leetCodeSolutionProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { markdownEngine } from "./markdownEngine";

class LeetCodeSolutionProvider extends LeetCodeWebview {

protected viewType: string = "leetcode.solution";
protected readonly viewType: string = "leetcode.solution";
private solution: Solution;
private sideMode: boolean = false;

Expand Down
2 changes: 1 addition & 1 deletion src/webview/leetCodeSubmissionProvider.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { markdownEngine } from "./markdownEngine";

class LeetCodeSubmissionProvider extends LeetCodeWebview {

protected viewType: string = "leetcode.submission";
protected readonly viewType: string = "leetcode.submission";
private result: string;

public async show(result: string): Promise<void> {
Expand Down