Skip to content

Apply vscode's markdown settings to MarkdownEngine #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2019
Merged

Apply vscode's markdown settings to MarkdownEngine #260

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9b46dd
apply markdown settings to MdEngine
Vigilans Apr 6, 2019
4f211a9
Resolve font family in windows
Vigilans Apr 6, 2019
8b79012
Address comment in review
Vigilans Apr 8, 2019
1a3cb57
Remove redundant type info
Vigilans Apr 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address comment in review
  • Loading branch information
@Vigilans
Vigilans committed Apr 8, 2019
commit 8b790123963d789764ae09bd59cdef66fc7f4095
4 changes: 2 additions & 2 deletions src/webview/markdownEngine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ class MarkdownConfiguration {
}

private resolveFontFamily(config: vscode.WorkspaceConfiguration): string | undefined {
let fontFamily: string | undefined = config.get<string | undefined>("preview.fontFamily", undefined);
if (isWindows() && fontFamily && fontFamily === config.inspect<string>("preview.fontFamily")!.defaultValue) {
let fontFamily: string = config.get<string>("preview.fontFamily", "");
if (isWindows() && fontFamily === config.inspect<string>("preview.fontFamily")!.defaultValue) {
fontFamily = `${fontFamily}, 'Microsoft Yahei UI'`;
}
return fontFamily;
Expand Down