Skip to content

Prepare for 0.13.0 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2019
Merged

Prepare for 0.13.0 #204

merged 3 commits into from
Mar 15, 2019

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Mar 13, 2019

No description provided.

@jdneo jdneo added this to the 0.13.0 milestone Mar 13, 2019
@jdneo jdneo marked this pull request as ready for review March 13, 2019 12:28
@jdneo jdneo requested a review from Vigilans March 13, 2019 12:28
Copy link
Contributor

@Vigilans Vigilans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution rendering logic is not applied to preview and result yet. Is the version set to 0.13.x when done?

README.md Outdated
@@ -70,14 +70,23 @@
<img src="https://raw.githubusercontent.com/jdneo/vscode-leetcode/master/docs/imgs/pick_problem.png" alt="Pick a Problem" />
</p>

- Right click the problem in the `LeetCode Explorer` and select `Show Problem` will generate a new file with the problem description for you.
- Right click the problem in the `LeetCode Explorer` and select `Preview Problem` to see the problem description. Or select `Show Problem` to directly open the file with the problem description.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left click the problem node would also trigger preview window, isn't it necessary to notify this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I'll add this.

@jdneo
Copy link
Member Author

jdneo commented Mar 14, 2019

yes, we can improve the rendering logic of preview and result in the later version, it's not a big problem.

@jdneo jdneo merged commit 0300764 into master Mar 15, 2019
@jdneo jdneo deleted the cs/0.13.0 branch March 15, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants