Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support leetcode-cn #50

Closed
Xeonacid opened this issue Jul 26, 2018 · 14 comments · Fixed by #57
Closed

Support leetcode-cn #50

Xeonacid opened this issue Jul 26, 2018 · 14 comments · Fixed by #57
Labels
enhancement New feature or request
Milestone

Comments

@Xeonacid
Copy link
Contributor

Xeonacid commented Jul 26, 2018

LeetCode 中国 is the Chinese version of LeetCode. It provides a more comfortable experience for Chinese users, I think.

However, data of the universal version and the Chinese version of LeetCode is not shared. If we want, we have to sync them manually. So can we choose which version to use? 😃

Thanks!

BTW, I have learned that this extension is based on the leetcode-cli project. Maybe I had better open an issue there...

@Xeonacid
Copy link
Contributor Author

duplicate, sorry for annoying

@jdneo
Copy link
Member

jdneo commented Jul 27, 2018

@Xeonacid I've received a lot of feedbacks about the LeetCode China. I think we can open an issue at the leetcode-cli repo and vote for it. Or even we can contribute for it.

Anyway, open an issue first is a good start I think.

@Xeonacid
Copy link
Contributor Author

@jdneo I have found something below

skygragon/leetcode-cli#93

https://github.com/skygragon/leetcode-cli-plugins/blob/master/plugins/leetcode.cn.js

I think these will be helpful...

@Xeonacid Xeonacid reopened this Jul 27, 2018
@jdneo
Copy link
Member

jdneo commented Jul 27, 2018

@Xeonacid Cool. Let me take a look.

@jdneo jdneo added the enhancement New feature or request label Jul 27, 2018
@jdneo jdneo added this to the 0.8.0 milestone Jul 27, 2018
@jdneo jdneo changed the title Is it able to use leetcode-cn? Support leetcode-cn? Aug 8, 2018
@jdneo jdneo changed the title Support leetcode-cn? Support leetcode-cn Aug 8, 2018
@zouyonghao
Copy link

I have tried leetcode-cn plugin for leetcode-cli and it works fine.

@jdneo
Copy link
Member

jdneo commented Aug 9, 2018

@zouyonghao Yes, I'm planning to add that plugin into the extension too. Will support leetcode.cn in next release.

@jdneo jdneo closed this as completed in #57 Aug 14, 2018
@jdneo jdneo reopened this Aug 14, 2018
@jdneo
Copy link
Member

jdneo commented Aug 14, 2018

@Xeonacid @zouyonghao Can you submit solution to leetcode-cn using leetcode-cli? From my side I'm always getting [ERROR] session expired, please login again [-1].

@zouyonghao
Copy link

@jdneo It seems there is a bug in leetcode.cn plugin, I have submit a pull request here
https://github.com/skygragon/leetcode-cli-plugins/pull/19/files

@jdneo
Copy link
Member

jdneo commented Aug 14, 2018

@zouyonghao Cool. Let's have some discussion there.

@jdneo
Copy link
Member

jdneo commented Aug 17, 2018

@zouyonghao Looks like the owner of leetcode-cli is busying with some stuff these ways.

I'm deciding to embed your changes when building the extension and publish it this week.

@zouyonghao
Copy link

@jdneo That's cool, appreciate your working.

@jdneo
Copy link
Member

jdneo commented Aug 18, 2018

@ALL

LeetCode for VS Code 0.8.0 has been published in marketplace. Please have a try.

@jdneo jdneo closed this as completed Aug 18, 2018
@Xeonacid
Copy link
Contributor Author

Xeonacid commented Aug 18, 2018

@jdneo @zouyonghao Thanks! Good job! It works fine 👍
BTW, does the leetcode-cli have any possibility to show Chinese problem name when using leetcode-cn? I've opened an issue skygragon/leetcode-cli-plugins#22

@jdneo
Copy link
Member

jdneo commented Aug 18, 2018

Haha, that could be a useful feature. Let’s tracking on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants