-
Notifications
You must be signed in to change notification settings - Fork 53
Add CI workflow for tests, formatting, and linting #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
austin-liminal
wants to merge
13
commits into
LeeMangold:main
Choose a base branch
from
austin-liminal:unruffled-lamarr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These screenshots demonstrate that the risk sorting fix works correctly: - Initial risk list displays properly - Department column sorting works without duplicates - Scope column sorting works without duplicates - Row count remains consistent across all sorting operations 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Created unit tests for User model (authentication, relationships, soft deletes) - Created unit tests for Control model (relationships, effectiveness tracking, enums) - Created unit tests for Applicability and Effectiveness enums - Created unit tests for QuotaService (quota checking, usage tracking, statistics) - Tests cover core functionality, relationships, and business logic - All tests pass with 72 tests and 165 assertions - Improves code quality and catches regressions 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Adds GitHub Actions workflow that runs on PRs to main: - PHPUnit tests via artisan test - Laravel Pint formatting check (fails if changes detected) - PHPStan static analysis Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The composer.lock has dependencies (lcobucci/clock, openspout/openspout) that require PHP 8.3+. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Configure SQLite instead of MySQL for CI environment - Create the database file before running artisan commands - Run migrations so settings table exists (required by AppServiceProvider) - Add SQLite extensions to PHPStan job Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
These commands need to run before the database is set up, so they should skip the settings table check in AppServiceProvider. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
784ea34 to
5e9e895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
php artisan testTest plan
🤖 Generated with Claude Code