fix: improve error handling for some edge cases [LIVE-14761] #198
+655
−491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrate to @reown/walletkit Added connect and disconnect notifications
ComradeAERGO
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Improve error handling for some edge cases on android with 100% loss
Migrate to @reown/walletkit
Added connect and disconnect notifications
❓ Context
📸 Demo
I had to trim and resize the demo as it was more than 100mb
And it was recorded before adding the connection notification
wc-android-error-handling-trim.mov
I also so a strange behaviour done by wallet-connect when loosing connection on the background on android and notify for connection non stop when going back on the app
wc-connection-status-bug.mov
🚀 Expectations to reach
Pull Requests must pass the CI and be internally validated in order to be merged.