fix: removing generated files from gconf#11
Merged
pthierry-ledger merged 4 commits intomainfrom Apr 2, 2025
Merged
Conversation
Tox is responsible for delivering these files using the build target. Moreover, if the working directory is dirty, ToX automatically increment the current version to a devX.<hash> instead of a given potential tag, to ensure that the delivered tarball do match the tag associated to a gconf state. This reason impose such a removing for proper delivery
pthierry-ledger
changed the title
pthierry-ledger
force-pushed
the
fix/pythonic-version
branch
from
a9d962e to
6e48841
Compare
pthierry-ledger
force-pushed
the
fix/pythonic-version
branch
from
6e48841 to
631e5b3
Compare
edelanghe-ledger
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove generated files from gconf has such a behavior is catched by ToX as generating a dirty working directory, and as such generates a dirty python tag.
The files, behing automatially generated by ToX, should stay out of the gconf part to ensure proper and reproducible tarball vs gconf.