feat(BACK-8135): add support for constant values#168
Merged
jnicoulaud-ledger merged 6 commits intomainfrom Dec 17, 2024
Merged
Conversation
Update to align with LedgerHQ/clear-signing-erc7730-registry#109 - [x] add support for constant `value` instead of `path` in all fields - [ ] add support for constant `token` instead of `tokenPath` when using `tokenAmount` format - [ ] add support for constant `collection` instead of `collectionPath` when using `nftName` format - [ ] add support for constant `callee` instead of `calleePath` when using `calldata` format
fsamier
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to align with LedgerHQ/clear-signing-erc7730-registry#109
valueinstead ofpathin all fieldstokeninstead oftokenPathwhen usingtokenAmountformatcollectioninstead ofcollectionPathwhen usingnftNameformatcalleeinstead ofcalleePathwhen usingcalldataformatNote: tests can't be green here and on the registry PR at the same time. I checked tests are green when pointing the submodule to LedgerHQ/clear-signing-erc7730-registry#109