Skip to content

fix: fix $id lost during input->resolved conversion #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnicoulaud-ledger merged 2 commits into from
Dec 5, 2024
Merged

fix: fix $id lost during input->resolved conversion #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e17c4c
fix: fix `$id` lost during input->resolved conversion
jnicoulaud-ledger Dec 5, 2024
95042f7
Merge branch 'main' into fix-id-lost
jnicoulaud-ledger Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/erc7730/convert/resolved/convert_erc7730_input_to_resolved.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def _resolve_context_contract(
if (contract := cls._resolve_contract(context.contract, out)) is None:
return None

return ResolvedContractContext(contract=contract)
return ResolvedContractContext.model_validate({"$id": context.id, "contract": contract})

@classmethod
def _resolve_contract(cls, contract: InputContract, out: OutputAdder) -> ResolvedContract | None:
Expand Down Expand Up @@ -201,7 +201,7 @@ def _resolve_context_eip712(cls, context: InputEIP712Context, out: OutputAdder)
if (eip712 := cls._resolve_eip712(context.eip712, out)) is None:
return None

return ResolvedEIP712Context(eip712=eip712)
return ResolvedEIP712Context.model_validate({"$id": context.id, "eip712": eip712})

@classmethod
def _resolve_eip712(cls, eip712: InputEIP712, out: OutputAdder) -> ResolvedEIP712 | None:
Expand Down
Loading