-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Description
When some ledgerctl commands fail, an error message can be written but the program returns a successful error code. For example:
$ ledgerctl info
No Ledger device has been found.
$ echo $?
0$ ledgerctl install-ca ledgerctl
The device is not in recovery mode.
$ echo $?
0It feels more natural to return an non-zero value for example in
Line 78 in 3d06e76
| sys.exit(0) |
Also, the message could be prefixed by something indicating that an error happened (for example Error: No Ledger device has been found. or [ERROR] No Ledger device has been found. or [!] No Ledger device has been found.). What do you think?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels