Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA-370][Detox] Update Detox for full react native 0.75 compatibility #8956

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Jan 20, 2025

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • Detox tests

📝 Description

Upon RN75 update we had to implement workaround as Detox synchronisation was broken. New Detox version is available with full compatibility.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 5:02pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 5:02pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 5:02pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 5:02pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 20, 2025
@abdurrahman-ledger abdurrahman-ledger changed the title Support/qaa 370 detox update [QAA-370][Detox] Update Detox for full react native 0.75 compatibility Jan 20, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant