Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CN-604: Change yield to earn for bitcoin on desktop and mobile #8358

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

CN-604: Change yield to earn for bitcoin on desktop and mobile #8358

wants to merge 6 commits into from
+123 −69

Conversation

adammino-ledger
Copy link
Contributor

@adammino-ledger adammino-ledger commented Nov 13, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes: changing a label for staking for Bitcoin only

📝 Description

This PR changes the entrypoint name for staking from Yield to Earn for Bitcoin.

❓ Context

JIRA-604

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@adammino-ledger adammino-ledger requested review from a team as code owners November 13, 2024 11:22
@vercel Vercel
Copy link

vercel bot commented Nov 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 5:03pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 5:03pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 5:03pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 18, 2024 5:03pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched labels Nov 13, 2024
KVNLS
KVNLS previously approved these changes Nov 13, 2024
View reviewed changes
LucasWerey
LucasWerey previously approved these changes Nov 13, 2024
View reviewed changes
Wozacosta
Wozacosta previously approved these changes Nov 13, 2024
View reviewed changes
@adammino-ledger adammino-ledger marked this pull request as draft November 14, 2024 13:59
@adammino-ledger
Copy link
Contributor Author

There is a change on the requirement for this so it cannot be merged for now till that's clear.

@mohammed-ledger mohammed-ledger marked this pull request as ready for review November 18, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasWerey LucasWerey LucasWerey left review comments

@KVNLS KVNLS KVNLS left review comments

@Wozacosta Wozacosta Wozacosta left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@adammino-ledger adammino-ledger

Labels
desktop Has changes in LLD mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adammino-ledger @Wozacosta @KVNLS @LucasWerey