Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[LIVE-14783]: Delete docs directory #8307

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aboissiere-ledger
Copy link
Collaborator

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

People don't seem to know what this folder is about. It is probably an initiative that was started and abandoned.
I prefer to have it removed because

  • a docs folder should have relevant content, this is not the case and it is giving a negative image
  • it publishes a npm package which has no purpose
  • it was maintained every time we made a next upgrade, even though it is not, to my knowledge, used

❓ Context

  • JIRA or GitHub link: LIVE-14783

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@aboissiere-ledger aboissiere-ledger requested a review from a team as a code owner November 5, 2024 15:34
Copy link

vercel bot commented Nov 5, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
ledger-live-docs ❌ Failed (Inspect) Nov 5, 2024 4:51pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 4:51pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 4:51pm
react-ui-storybook ⬜️ Ignored (Inspect) Nov 5, 2024 4:51pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Nov 5, 2024 4:51pm

@aboissiere-ledger aboissiere-ledger changed the title chore(LIVE-14783): Delete docs directory and package chore [LIVE-14783]: Delete docs directory and package Nov 5, 2024
@aboissiere-ledger aboissiere-ledger changed the title chore [LIVE-14783]: Delete docs directory and package chore[LIVE-14783]: Delete docs directory and package Nov 5, 2024
@aboissiere-ledger aboissiere-ledger changed the title chore[LIVE-14783]: Delete docs directory and package chore[LIVE-14783]: Delete docs directory Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants