🔍 feat(lld): Track users creating or joining a Ledger keyring on LLD #8283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
thesan
force-pushed
the
feat/lld-lkrp-getorcreate-analytics
branch
from
7d25c04
to
0201186
Compare
themooneer
reviewed
Nov 4, 2024
| }); | ||
| }); | ||
| }); | ||
|
|
There was a problem hiding this comment.
i would move this bloc to the top before using the variables
There was a problem hiding this comment.
Do you mean the beforeEach ?
There was a problem hiding this comment.
no the variable declarations , mock setups starting from line 134
themooneer
previously approved these changes
Nov 4, 2024
LucasWerey
previously approved these changes
Nov 4, 2024
themooneer
previously approved these changes
Nov 4, 2024
thesan
force-pushed
the
feat/lld-lkrp-getorcreate-analytics
branch
from
4f8732c
to
8869638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Track users creating and joining a Ledger keyring on LLD and test the
useAddMemberhook. The rest of the issue will be done in followup PRs.❓ Context
🧐 Checklist for the PR Reviewers