Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨(lld): add hide inscription feature #7966

Merged
merged 1 commit into from
Oct 3, 2024
Merged

✨(lld): add hide inscription feature #7966

merged 1 commit into from
Oct 3, 2024

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Oct 1, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Settings
    • Ordinals
    • ledgerhq/live-nft-react, ledgerhq/live-nft

📝 Description

Add hide inscription feature for ordis

Screen.Recording.2024-10-02.at.11.58.39.mov

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Oct 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 0:14am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 0:14am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 0:14am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 0:14am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 3, 2024 0:14am

@live-github-bot live-github-bot bot added desktop Has changes in LLD translations Translation files have been touched labels Oct 1, 2024
@LucasWerey LucasWerey force-pushed the feat/LIVE-14293 branch 4 times, most recently from cc7e09a to e8fd5da Compare October 2, 2024 09:39
@LucasWerey LucasWerey marked this pull request as ready for review October 2, 2024 09:55
@LucasWerey LucasWerey requested review from a team as code owners October 2, 2024 09:55
@LucasWerey LucasWerey force-pushed the feat/LIVE-14293 branch 2 times, most recently from c97f979 to 7d70df5 Compare October 3, 2024 09:59
@KVNLS KVNLS merged commit 81432cb into develop Oct 3, 2024
48 of 52 checks passed
@KVNLS KVNLS deleted the feat/LIVE-14293 branch October 3, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrellard-ledger cgrellard-ledger cgrellard-ledger approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger left review comments

Assignees

@LucasWerey LucasWerey

Labels
desktop Has changes in LLD translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LucasWerey @cgrellard-ledger @ypolishchuk-ledger @KVNLS