Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLD - Fix react-devtools to use latest automatically #7960

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 1, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Last year we were not able to load the latest version of react-devtools due to an Electron issue, it's fixed now.
image

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Oct 1, 2024
@KVNLS KVNLS requested a review from a team as a code owner October 1, 2024 12:53
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 1:10pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 1:10pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 1:10pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 1:10pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 1:10pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD tools Has changes in tools labels Oct 1, 2024
themooneer
themooneer previously approved these changes Oct 1, 2024
Copy link
Member

@valpinkman valpinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aw yiiis

@KVNLS KVNLS merged commit 23b2710 into develop Oct 1, 2024
40 of 42 checks passed
@KVNLS KVNLS deleted the fix/react-devtools-latest branch October 1, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD tools Has changes in tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants