Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llm): πŸ” accept analytics during onboarding tests #7959

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Oct 1, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

The onboarding test will tap on the "Accept all" button of the analytics prompt if the prompt shows.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested review from a team as code owners October 1, 2024 10:50
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 1, 2024 10:51am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 1, 2024 10:51am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 1, 2024 10:51am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 1, 2024 10:51am
web-tools ⬜️ Ignored (Inspect) Oct 1, 2024 10:51am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Oct 1, 2024
@thesan thesan merged commit 94b2e3d into develop Oct 1, 2024
44 of 46 checks passed
@thesan thesan deleted the chore/llm-e2e-onboarding-analytics-prompt branch October 1, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants