Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve ledger sync tests #7958

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

KVNLS
Copy link
Member

@KVNLS KVNLS commented Oct 1, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Fix usage of await in integration tests.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@KVNLS KVNLS self-assigned this Oct 1, 2024
@KVNLS KVNLS requested a review from a team as a code owner October 1, 2024 10:25
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Oct 1, 2024 10:25am
ledger-live-github-bot ⬜️ Ignored (Inspect) Oct 1, 2024 10:25am
native-ui-storybook ⬜️ Ignored (Inspect) Oct 1, 2024 10:25am
react-ui-storybook ⬜️ Ignored (Inspect) Oct 1, 2024 10:25am
web-tools ⬜️ Ignored (Inspect) Oct 1, 2024 10:25am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Oct 1, 2024
@KVNLS KVNLS merged commit 98f0ae7 into develop Oct 1, 2024
51 checks passed
@KVNLS KVNLS deleted the fix/improve-ledger-sync-inte-tests branch October 1, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants