Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TON support for Swap (and Exchange in general) #7952

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Add TON support for Swap (and Exchange in general) #7952

merged 8 commits into from
Oct 17, 2024

Conversation

sprohaszka-ledger
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger commented Sep 30, 2024 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Update Wallet-API core version to support TON serialization.
Update partner's info test format to be consistent with CAL format.
Add more integration test in AppExchange with dedicated TON payload.
Fix infinite loader issue when DISABLE_BROADCAST and use old swap UI.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 0:12am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 0:12am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 0:12am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 0:12am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2024 0:12am

@live-github-bot live-github-bot bot added common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Sep 30, 2024
@sprohaszka-ledger sprohaszka-ledger marked this pull request as ready for review October 4, 2024 09:28
@sprohaszka-ledger sprohaszka-ledger requested review from a team as code owners October 4, 2024 09:28
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 16, 2024
Justkant
Justkant reviewed Oct 16, 2024
View reviewed changes
turbo.json Show resolved Hide resolved
@sprohaszka-ledger
feat(swap): add support of ton
04e7a54 
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
@sprohaszka-ledger
fix(swap): infinite loader with DISABLE_BROADCAST activated
4bef358 
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
@sprohaszka-ledger
fix: rebase issue
7a07e92 
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
@sprohaszka-ledger
chore: revert some undesired modification
8331958 
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
andreicovaciu
andreicovaciu reviewed Oct 17, 2024
View reviewed changes
libs/ledger-live-common/src/exchange/providers/index.ts Outdated
@@ -48,26 +48,29 @@ export const getProviderConfig = async (
}
};

let testProvider: ExchangeProviderNameAndSignature | undefined;
export let testProvider: ExchangeProviderNameAndSignature | undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of exporting it, might be better to create a getter for it?

@sprohaszka-ledger
chore: feedback
c1c2497 
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
@sprohaszka-ledger
fix: lint issue
c78589b 
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
Justkant
Justkant reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@Justkant Justkant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the question for the commented constants
We need to redo the pnpm i with a fresh lock file from develop
And add a changeset and we're good

@sprohaszka-ledger
chore: revert pnpm-lock file
04a5f0d 
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
@sprohaszka-ledger
chore: changelog
12908af 
Signed-off-by: Stéphane Prohaszka <stephane.prohaszka@ledger.fr>
@sprohaszka-ledger sprohaszka-ledger merged commit d6c9096 into develop Oct 17, 2024
57 checks passed
@sprohaszka-ledger sprohaszka-ledger deleted the feat/LIVE-13901-swap-ton branch October 17, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreicovaciu andreicovaciu andreicovaciu approved these changes

@Justkant Justkant Justkant approved these changes

Assignees

@sprohaszka-ledger sprohaszka-ledger

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sprohaszka-ledger @Justkant @andreicovaciu