✨(lld): add actions in ordis drawer #7951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
LucasWerey
force-pushed
the
feat/LIVE-14261
branch
from
8dc6c01
to
6ceb587
Compare
LucasWerey
force-pushed
the
feat/LIVE-14261
branch
from
6ceb587
to
add96ed
Compare
thesan
reviewed
Sep 30, 2024
| @@ -7,7 +7,9 @@ import { BitcoinAccount } from "@ledgerhq/coin-bitcoin/lib/types"; | |||
| import { useBitcoinAccountModel } from "./useBitcoinAccountModel"; | |||
| import InscriptionDetailsDrawer from "../../components/Inscriptions/DetailsDrawer"; | |||
|
|
|||
| type ViewProps = ReturnType<typeof useBitcoinAccountModel>; | |||
| type ViewProps = ReturnType<typeof useBitcoinAccountModel> & { | |||
There was a problem hiding this comment.
Why not adding account to the return type of useBitcoinAccountModel ?
There was a problem hiding this comment.
No real reason just find it more explicit to do this way. So we know that we don't change account in the Model
...p/src/newArch/features/Collectibles/Ordinals/components/Inscriptions/DetailsDrawer/index.tsx
Outdated
Show resolved
Hide resolved
apps/ledger-live-desktop/src/newArch/features/Collectibles/utils/typeGuardsChecker.ts
Outdated
Show resolved
Hide resolved
themooneer
reviewed
Sep 30, 2024
| })), | ||
|
|
||
| ...(marketplacePages.length > 0 ? [{ id: "sep2", type: "separator", label: "" }] : []), | ||
| explorerLink && { |
There was a problem hiding this comment.
if explorerLink is falsy, you will get an unwanted false value in your array
themooneer
reviewed
Sep 30, 2024
| ]); | ||
| } else { | ||
| const linksRecord = links as Record<string, string>; | ||
| return safeList([ |
There was a problem hiding this comment.
same here , avoid having a [false, false, false] or mixed with false array type
themooneer
reviewed
Sep 30, 2024
| import { NFTMetadata, ProtoNFT } from "@ledgerhq/types-live"; | ||
| import { isNFTMetadata } from "../utils/typeGuardsChecker"; | ||
| import { createOrdinalExplorerUrl } from "../utils/createOrdinalExplorerUrl"; | ||
|
|
There was a problem hiding this comment.
(suggestion) can you summarise in few words what this hook stands for please?
themooneer
reviewed
Sep 30, 2024
apps/ledger-live-desktop/src/newArch/features/Collectibles/hooks/useHideCollection.ts
Outdated
Show resolved
Hide resolved
themooneer
reviewed
Sep 30, 2024
apps/ledger-live-desktop/src/newArch/features/Collectibles/hooks/useCreateLinks.tsx
Outdated
Show resolved
Hide resolved
LucasWerey
force-pushed
the
feat/LIVE-14261
branch
from
add96ed
to
e743121
Compare
themooneer
approved these changes
Oct 1, 2024
thesan
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Refactor hooks that implements the actions inside nft/ordis drawer so it works using our nft metadata and simplehash API
Inscriptions can be seen on magicEden / ordinals.com or set as custom lock screen on stax/flex
Screen.Recording.2024-09-30.at.15.51.47.mov
❓ Context
🧐 Checklist for the PR Reviewers