Send nightly iOS builds to new "Ledger Live (nightly)" app in Testflight #7949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
from
2c2a7ff
to
d1f0ce8
Compare
angusbayley
changed the title
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
2 times, most recently
from
2143d5a
to
6f6e517
Compare
angusbayley
changed the title
themooneer
reviewed
Oct 2, 2024
themooneer
previously approved these changes
Oct 2, 2024
themooneer
reviewed
Oct 2, 2024
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
from
6f6e517
to
427c7c8
Compare
live-github-bot
bot
added
desktop
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
from
427c7c8
to
06cbef1
Compare
live-github-bot
bot
removed
desktop
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
from
06cbef1
to
7c15154
Compare
angusbayley
commented
Oct 2, 2024
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
from
7c15154
to
3effb30
Compare
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
from
3effb30
to
525ff0f
Compare
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
from
525ff0f
to
78aff3f
Compare
themooneer
reviewed
Oct 3, 2024
themooneer
reviewed
Oct 3, 2024
themooneer
reviewed
Oct 3, 2024
themooneer
previously approved these changes
Oct 3, 2024
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
from
f46b61c
to
347fe47
Compare
…r for staging and prerelease
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
from
347fe47
to
1b1c64f
Compare
| "idiom" : "ipad", | ||
| "filename" : "Icon-Small-50x50@1x.png", | ||
| "scale" : "1x" | ||
| "filename" : "Icon-App-40x40@3x 1.png", |
There was a problem hiding this comment.
Weird filename. Is it an error? Also why are we modifying icons of the Prod app?
There was a problem hiding this comment.
I'm not sure how this happened exactly, but I know Xcode makes lots of automatic updates in this directory whenever you adjust any icon settings. I did confirm that the icon set wasn't corrupted in this change, but as a precaution I have reverted all AppIcon changes for the main app - see latest commit
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
from
730c1db
to
c92b435
Compare
themooneer
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
Creates a new configuration in Xcode for nightly builds, with a new associated bundle id. The iOS
buildlane is updated so CI nightly builds use this config when callinggym(). New app icons (same as production except red instead of black) are added and linked to this configuration.Nightly builds build appear in Testflight under this new app, called "Ledger Live (nightly/staging)":
The icon set has been updated since the previous screenshot. Latest is:
❓ Context
https://ledgerhq.atlassian.net/browse/LIVE-13485
🧐 Checklist for the PR Reviewers