Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lld): retry app installation upon device disconnection #7946

Conversation

fAnselmi-Ledger
Copy link
Contributor

@fAnselmi-Ledger fAnselmi-Ledger commented Sep 27, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

Retry app installation upon device disconnection

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@fAnselmi-Ledger fAnselmi-Ledger requested a review from a team as a code owner September 27, 2024 15:47
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 10:14am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 10:14am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 10:14am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 10:14am
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 10:14am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 27, 2024
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the bugfix/LIVE-13482-LLD-Sync-onboarding-A-black-screen-appears-when-the-user-disconnects-their-device-during-application-installation branch 3 times, most recently from fee01ba to 7a11a82 Compare September 30, 2024 09:56
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the bugfix/LIVE-13482-LLD-Sync-onboarding-A-black-screen-appears-when-the-user-disconnects-their-device-during-application-installation branch from 7a11a82 to 52ced1f Compare October 15, 2024 15:24
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the bugfix/LIVE-13482-LLD-Sync-onboarding-A-black-screen-appears-when-the-user-disconnects-their-device-during-application-installation branch from 52ced1f to df23c6f Compare October 21, 2024 10:07
@fAnselmi-Ledger fAnselmi-Ledger merged commit cbe7a69 into develop Oct 22, 2024
42 checks passed
@fAnselmi-Ledger fAnselmi-Ledger deleted the bugfix/LIVE-13482-LLD-Sync-onboarding-A-black-screen-appears-when-the-user-disconnects-their-device-during-application-installation branch October 22, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants