Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🧹 fix types errors in @ledgerhq/trustchain tests #7945

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Sep 27, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Remove the missing jest types issues in the Trustchain tests files:

Before After
image image

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@thesan thesan requested a review from a team as a code owner September 27, 2024 15:24
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 10:44am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 10:44am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 10:44am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 10:44am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 30, 2024 10:44am

@thesan thesan force-pushed the chore/trustchain-tests-type-errors branch from f1d3b20 to 4c1dec7 Compare September 30, 2024 10:38
@thesan thesan merged commit a47e68b into develop Sep 30, 2024
55 checks passed
@thesan thesan deleted the chore/trustchain-tests-type-errors branch September 30, 2024 12:12
bharamboure-ledger pushed a commit that referenced this pull request Oct 1, 2024
chore: fix types errors in `@ledgerhq/trustchain` tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants