Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIVE-14281] Feature - EIP712 supports filters with empty arrays #7943

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Sep 27, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • No impact before 1.12.0
    • After 1.12.0 filters can work with empty arrays / discarded paths

📝 Description

hw-app-eth now supports discarding paths for filters of empty values.
https://github.com/LedgerHQ/app-ethereum/blob/develop/doc/ethapp.adoc#discarded-filter-path

All the EIP712 test APDUs have been snapshotted again with the CAL test key so anyone can validate and update them if needed.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lambertkevin lambertkevin requested a review from a team as a code owner September 27, 2024 13:36
Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Sep 27, 2024 1:38pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Sep 27, 2024 1:38pm
native-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2024 1:38pm
react-ui-storybook ⬜️ Ignored (Inspect) Sep 27, 2024 1:38pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2024 1:38pm

@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Sep 27, 2024
Copy link
Contributor

@Wozacosta Wozacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪄 🧙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants