Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA-168] Adding new send test cases #7938

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[QAA-168] Adding new send test cases #7938

merged 1 commit into from
Oct 1, 2024

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Sep 27, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Adding new send test scénarios:

  • Valid Address
  • Invalid Address

CI Run: https://github.com/LedgerHQ/ledger-live/actions/runs/11069828999 (fail = getAppAndVersion)

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 2:19pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 2:19pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 2:19pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 2:19pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 2:19pm

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Sep 27, 2024
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Sep 27, 2024

Wiz Scan Summary

Scan Module Critical High Medium Low Info Total
IaC Misconfigurations 0 0 0 0 0 0
Sensitive Data 0 0 0 0 1 1
Secrets 0 0 0 0 0 0
Total 0 0 0 0 1 1

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@VicAlbr VicAlbr marked this pull request as ready for review September 27, 2024 11:46
@VicAlbr VicAlbr requested review from a team as code owners September 27, 2024 11:46
@VicAlbr VicAlbr force-pushed the support/qaa168 branch 2 times, most recently from f5338ff to 37afb46 Compare October 1, 2024 14:17
@VicAlbr VicAlbr merged commit 81a0324 into develop Oct 1, 2024
46 of 47 checks passed
@VicAlbr VicAlbr deleted the support/qaa168 branch October 1, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants