Ledger Sync - Fix side effect causing the synchronization to stop working #7929
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
mcayuelas-ledger
previously approved these changes
Sep 27, 2024
cgrellard-ledger
force-pushed
the
bugfix/ledger-sync-synchronization-not-working
branch
from
8a72596
to
5855fcc
Compare
cgrellard-ledger
force-pushed
the
bugfix/ledger-sync-synchronization-not-working
branch
from
5855fcc
to
04f4493
Compare
LucasWerey
approved these changes
Oct 1, 2024
cgrellard-ledger
deleted the
bugfix/ledger-sync-synchronization-not-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
This PR fixes an issue that caused the synchronization to be broken for an instance in the following situation :
When the local wallet sync state version was different than the one returned by the cloud sync api (when pushing or pulling data) and the
resolveIncrementalUpdatefunction didn't detect any changes between the latestState and the distantState, the local version wasn't updated and all subsequent call to the cloud sync api were returning an out of sync state.This is fixed by updating the local version to the value returned by the cloud sync api even if there were no differences between the latest data and the distant data. That way the following calls made to pull data from the cloud sync api will be successfull and the synchronization will keep working.
❓ Context
🧐 Checklist for the PR Reviewers